Add itemCount to SentryEnvelopeItemHeader#5230
Conversation
denrase
requested review from
armcknight,
philipphofmann and
philprime
as code owners
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add `itemCount` to `SentryEnvelopeItemHeader` ([#5230](https://github.com/getsentry/sentry-cocoa/pull/5230))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 04c0c68 | 1223.22 ms | 1251.24 ms | 28.02 ms |
| ddb4778 | 1245.36 ms | 1254.16 ms | 8.80 ms |
| bdfdf18 | 1230.33 ms | 1240.04 ms | 9.72 ms |
| de46f06 | 1255.53 ms | 1268.44 ms | 12.91 ms |
| d8bb3eb | 1230.53 ms | 1248.62 ms | 18.09 ms |
| 07b120c | 1227.48 ms | 1235.14 ms | 7.66 ms |
| 1b69ee7 | 1216.53 ms | 1226.69 ms | 10.16 ms |
| 0ff6aa3 | 1216.92 ms | 1231.44 ms | 14.52 ms |
| 2f9c5f9 | 1218.78 ms | 1239.58 ms | 20.80 ms |
| 92bc771 | 1236.60 ms | 1245.67 ms | 9.07 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 04c0c68 | 22.85 KiB | 414.09 KiB | 391.24 KiB |
| ddb4778 | 21.58 KiB | 414.92 KiB | 393.34 KiB |
| bdfdf18 | 22.30 KiB | 848.26 KiB | 825.95 KiB |
| de46f06 | 22.85 KiB | 414.74 KiB | 391.89 KiB |
| d8bb3eb | 22.31 KiB | 765.79 KiB | 743.48 KiB |
| 07b120c | 21.58 KiB | 614.90 KiB | 593.32 KiB |
| 1b69ee7 | 21.58 KiB | 707.43 KiB | 685.85 KiB |
| 0ff6aa3 | 23.76 KiB | 868.90 KiB | 845.14 KiB |
| 2f9c5f9 | 21.58 KiB | 418.82 KiB | 397.24 KiB |
| 92bc771 | 21.58 KiB | 699.30 KiB | 677.72 KiB |
denrase
changed the title
itemCount to SentryEnvelopeItemHeader
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5230 +/- ##
=============================================
- Coverage 92.895% 92.816% -0.080%
=============================================
Files 683 684 +1
Lines 85881 85930 +49
Branches 31146 30073 -1073
=============================================
- Hits 79780 79757 -23
- Misses 5998 6078 +80
+ Partials 103 95 -8
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@buenaflor FYI |
|
@denrase UI tests are failing but not sure if it's due to flakiness |
denrase
requested review from
NicoHinderling,
itaybre,
noahsmartin and
trevor-e
as code owners
philprime
left a comment
philprime
left a comment
There was a problem hiding this comment.
LGTM 👍
Thank you for adding the additional test, I did not know that SentryEnvelopeTests already existed, otherwise I would not have proposed adding the SentryEnvelopeItemHeaderTests.
|
Looks like the formatter bot did not trigger checks (as expected). You can add a comment somewhere, then push another commit and it should trigger CI |
|
The formatter bot commits are not expected to rerun the full check suite again. |
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
5 participants
📜 Description
Add
itemCounttoSentryEnvelopeItemHeader. We need this sologenvelopes can be sent from flutter and other hybrid SDKs.Specs: https://develop.sentry.dev/sdk/telemetry/logs/#log-envelope-item
💡 Motivation and Context
Relates to getsentry/sentry-dart#2919
💚 How did you test it?
Added unit test. Tested in flutter app.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.